New .gitignore pattern, CC1101 streaming mode, RF69 SPI get/set/read/write overrides #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested: CC1101_Receive, CC1101_Receive_Interrupt, CC1101_Transmit, CC1101_Transmit_Interrupt
* 'master' of github.com:rfquack/RadioLib: (135 commits) [CC1101] Added bitrate caching. [nRF24] Removed ambiguity, PR jgromes#119 [nRF24] Minor fixes [nRF24] Added "isCarrierDetected()" Bump version to 3.3.1 [SX127x] Set OOK parameter before setting the bitrate to avoid reading undefined variable [Module] Fixed incorrect arguments [Module] Fixed interface termination [SX1231] Removed old call to SPI end [RF69] Removed old call to SPI end [CC1101] Removed old call to SPI end [CC1101] Removed redundant null terminator [nRF24] Removed redundant null terminator [RF69] Removed redundant null terminator [CC1101] Requested changes PR jgromes#114 [CC1101] Fixed interrupt direction. Tested: CC1101_Receive, CC1101_Receive_Interrupt, CC1101_Transmit, CC1101_Transmit_Interrupt [CC1101] Receive up to 255 bytes [CC1101] Transmit up to 255 bytes [CC1101] Added carrier sense as sync word qualifier [CC1101] Update cached len value. ...
Fixed compiling issues
* upstream/master: (249 commits) [SX127x] OOK functions style cleanup [RF69] OOK functions style cleanup styles and syntax changes added RF69::setOokThresholdType added RF69::setLnaTestBoost doc fix SX1278::getRSSI() modified for OOK so it wont require an activation SX127x::setOokPeakThresholdDecrement ignore jetbrain .idea SX1278::setGain() added support for FSK_OOK modes SX127x::setOokFixedOrFloorThreshold SX1278::setOokThresholdType() RF69::setOOK [SX127x] Fixed shaping in OOK (jgromes#268) [SX127x] Added FSK CRC mode configuration (jgromes#266) Bump version to 4.3.0 [nRF24] Added low-level access macro [XBee] Added low-level access macro [Si443x] Added low-level access macro [SX128x] Added low-level access macro ...
* 'master' of github.com:rfquack/RadioLib: [RF69] Fixed setOOK() [CC1101] Fix in promiscuous mode Fixed compiling issues
jgromes
requested changes
Apr 13, 2021
There was a problem hiding this comment.
Thanks, I left some comments. Overall the biggest change is probably the stream mode for CC1101 - is that something that could be done more generically, e.g. using approach outlined in #201? And what's the current maximum data length for CC1101, is it unlimited now?
|
Added a bunch of changes and comments. LMK what you think. |
jgromes
reviewed
Apr 14, 2021
jgromes
reviewed
Apr 14, 2021
|
Added some changes. |
jgromes
approved these changes
Apr 22, 2021
|
Merged, thanks for the continued contributions guys :) Release 4.4.0 coming up shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignorepattern to prevent that.pio*files get sucked up (PlatformIO users will be happy)