Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden compatibility with symfony/process #261

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

jonpugh
Copy link
Contributor

@jonpugh jonpugh commented Jan 20, 2023

Updates "Fixed compatibility with Symfony\Process v4+ for Drush driver. #251".

I don't know why, I can't explain it. A project has symfony/process 4.4.4, but still, does NOT have the method "fromShellCommandline".

I noticed that another part of symfony/console actually checks for this method to remain compatible, I guess?

Can do this so that the driver works everywhere?

    $process = method_exists(Process::class, 'fromShellCommandline') ? Process::fromShellCommandline($cmd) : new Process($cmd);

https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Console/Helper/ProcessHelper.php#L57

Updates "Fixed compatibility with Symfony\Process v4+ for Drush driver. jhedstrom#251"
@jhedstrom
Copy link
Owner

Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants