Add types on generator-cicd #28427
Open
Add types on generator-cicd #28427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Can this code get a review? It aligns the cicd generator with the new 'command' approach. So that I can move on to the next generator... |
mraible
reviewed
Jan 29, 2025
| "ciCdAny": false, | ||
| "ciCdAzure": false, | ||
| "ciCdCircle": false, | ||
| "ciCdGithub": false, |
There was a problem hiding this comment.
Should Hub be capitalized like it is in GitHub?
| "ciCdIntegrationsSnyk": false, | ||
| "ciCdIntegrationsSonar": false, | ||
| "ciCdJenkins": false, | ||
| "ciCdTravis": false, |
There was a problem hiding this comment.
Is Travis still being used by developers?
| @@ -835,6 +859,9 @@ exports[`generator - app with default config should match snapshot 1`] = ` | |||
| "skipJhipsterDependencies": undefined, | |||
| "skipServer": undefined, | |||
| "skipUserManagement": false, | |||
| "sonarName": undefined, | |||
| "sonarOrga": undefined, | |||
| @@ -41,13 +49,16 @@ const command: JHipsterCommandDefinition = { | |||
| { name: 'Travis CI', value: 'travis' }, | |||
| { name: 'CircleCI', value: 'circle' }, | |||
| ], | |||
| scope: 'context', | |||
| scope: 'storage', | |||
There was a problem hiding this comment.
Why did the scope value change?
| }, | ||
| default: 'snapshots', | ||
| scope: 'context', | ||
| default: 'snapshots', |
There was a problem hiding this comment.
Is there a formatting issue here?
| type: String, | ||
| }, | ||
| prompt: gen => ({ | ||
| when: answers => answers.ciCd?.includes('jenkins') && answers.ciCdIntegrations?.includes('sonar'), |
| ).length !== this.jhipsterConfig.ciCd.length | ||
| ) { | ||
| throw new Error( | ||
| `error: command-argument value '${this.jhipsterConfig.ciCd}' is invalid for argument 'ciCd'. Allowed choices are github, jenkins, gitlab, azure, travis, circle.`, |
There was a problem hiding this comment.
I don't know if "command-argument value" would make sense to me in an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types on generator-cicd
Contributes to #28235
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.