Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1177 Updated the Heroku Deploy docs according to the new announcement #1182

Merged
merged 2 commits into from
Oct 10, 2022
Merged

#1177 Updated the Heroku Deploy docs according to the new announcement #1182

merged 2 commits into from
Oct 10, 2022

Conversation

prokan468
Copy link
Contributor

@prokan468 prokan468 commented Oct 8, 2022 •
edited
Loading

[skip ci]

@prokan468
Fixed Heroku Deploy Doc
b816ea1 
Removed mention about free dynos/resources and made it clear that a paid plan is required
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@prokan468 prokan468 mentioned this pull request Oct 9, 2022
Closed
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prokan468
Copy link
Contributor Author

Hi, @ivanmonteiro I have made the changes. Please do review it again and let me know if there are any more changes to be made.

@nicolas63
Copy link
Member

Looks good to me if @ivanmonteiro are ok i can merge

@ivanmonteiro
Copy link
Contributor

Looks good to me if @ivanmonteiro are ok i can merge

Looks good to me

@prokan468
Copy link
Contributor Author

Thanks @ivanmonteiro and @nicolas63 . Appreciate it! Please do merge this PR.

@prokan468
Copy link
Contributor Author

I am not sure as to why this is failing two checks, which it wasn't earlier. @nicolas63 Do I do something from my side or would that be taken care of by you?

@nicolas63
Copy link
Member

It's not on your side, i will rerun the pipeline

@nicolas63 nicolas63 merged commit e58837f into jhipster:main Oct 10, 2022
@nicolas63
Copy link
Member

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmonteiro ivanmonteiro Awaiting requested review from ivanmonteiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prokan468 @CLAassistant @nicolas63 @ivanmonteiro