Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

use i18n date time formatting for timestamps where possible #464

Merged

Conversation

atomfrede
Copy link
Member

closes #177

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@atomfrede atomfrede force-pushed the 177-use-i18n-date-time-formatting branch 3 times, most recently from cbdda6c to 2be0a73 Compare October 7, 2019 05:39
@atomfrede
Copy link
Member Author

atomfrede commented Oct 15, 2019

🤔 Something went wrong during rebase 👎 Will have a look and fix it.

Better now. Hopefully I can finish it during this week.

@atomfrede atomfrede force-pushed the 177-use-i18n-date-time-formatting branch from c1e653e to 40f0733 Compare October 15, 2019 18:14
@pascalgrimaud
Copy link
Member

@atomfrede : FYI, @nonomoho is working on fixing the current build. We encountered some issue related to date / instant etc...
It looks like this PR is for another thing, but I wanted to let you know

@atomfrede atomfrede force-pushed the 177-use-i18n-date-time-formatting branch from 40f0733 to b8254a5 Compare October 21, 2019 05:17
@atomfrede atomfrede force-pushed the 177-use-i18n-date-time-formatting branch from 6dfa4d7 to 5dec931 Compare December 1, 2019 19:35
@atomfrede atomfrede marked this pull request as ready for review December 1, 2019 21:27
@atomfrede
Copy link
Member Author

This PR is ready to merge now. All dates are now formatted via vue-i18n which uses the native Intl Api. Right now the date is parsed on demand. When doing #482 it must not be done (will be a separate PR).

@atomfrede
Copy link
Member Author

Thats how it looks like (before we had the same pattern in every language)

Screenshot_2019-12-02 datei18n(3)
Screenshot_2019-12-02 datei18n(2)
Screenshot_2019-12-02 datei18n(1)
Screenshot_2019-12-02 datei18n

@clementdessoude
Copy link
Contributor

It looks very cool @atomfrede !

@pascalgrimaud pascalgrimaud merged commit e42877c into jhipster:master Dec 2, 2019
@atomfrede
Copy link
Member Author

@atomfrede atomfrede deleted the 177-use-i18n-date-time-formatting branch January 18, 2020 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use vue-i18n date time localization
4 participants