Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Add Promise Reject in case of an error #543

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud commented Feb 9, 2020

Cherry pick from #467

  • rebase against master

Fix #466


  • Please make sure the below checklist is followed for Pull Requests.

  • Azure tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@pascalgrimaud
Copy link
Member Author

The build failed with this stackstrace:

Jest: "global" coverage threshold for functions (70%) not met: 66.5%

Test Suites: 112 passed, 112 total
Tests:       425 passed, 425 total
Snapshots:   0 total
Time:        61.722s
Ran all test suites.

It means we need to add some tests to cover this new code

@pascalgrimaud
Copy link
Member Author

Resolved in the last commit. I'm merging this

@pascalgrimaud pascalgrimaud merged commit dc4835a into jhipster:master Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try-Catch not working as expected
2 participants