Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate GitHub Pages deployment #672

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jtkiesel
Copy link
Contributor

What changed with this PR:

GitHub Pages deployment (to https://www.jhipster.tech/prettier-java/) is automated.

Relative issues or prs:

Obsoletes #649

@jtkiesel jtkiesel force-pushed the ci/deploy-github-pages branch 12 times, most recently from b374b5a to 0219749 Compare June 18, 2024 06:20
@jtkiesel jtkiesel force-pushed the ci/deploy-github-pages branch from 0219749 to 38480ed Compare June 18, 2024 06:25
Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should target node 20 by default

.github/workflows/github-pages-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/github-pages-test.yml Outdated Show resolved Hide resolved
@jtkiesel jtkiesel force-pushed the ci/deploy-github-pages branch from 38480ed to 59953ff Compare June 19, 2024 02:56
@jtkiesel jtkiesel requested a review from DanielFran June 19, 2024 02:57
@DanielFran DanielFran merged commit f03c554 into jhipster:main Jun 19, 2024
7 checks passed
@DanielFran
Copy link
Member

@jtkiesel the deployment is failing.
Can you check?

@jtkiesel
Copy link
Contributor Author

jtkiesel commented Jun 20, 2024

@DanielFran I don't appear to have access to this repository's settings, so assuming you do, could you please do the following?

  1. Go to Settings > Pages and change Source to GitHub Actions? I am assuming it is currently set to Deploy from a Branch.
  2. Go to Settings > Environments > github-pages and under Deployment branches change the allowed branch to main. I am assuming it is currently set to gh-pages.

@DanielFran
Copy link
Member

Thanks @jtkiesel, the pipeline now deploys the site correctly

@jtkiesel jtkiesel deleted the ci/deploy-github-pages branch June 21, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants