Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes merging of IDs from mal-id-cache in indexers #279

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Conversation

irfan-dahir
Copy link
Contributor

@irfan-dahir irfan-dahir commented Oct 1, 2022

For some reason

$ids = $ids['sfw'] + $ids['nsfw']; // merge

This does not work. The NSFW array does not get included in the storage output of the next line.

Storage::put('indexer/manga_mal_id_sweep.json', json_encode($ids));

No clue why. #justPHPThings


This works instead:

$ids = array_merge($ids['sfw'], $ids['nsfw']);

@irfan-dahir irfan-dahir added the bug label Oct 1, 2022
@irfan-dahir irfan-dahir requested review from nerg4l and pushrbx October 1, 2022 18:55
@nerg4l nerg4l merged commit 02107d9 into master Oct 1, 2022
@irfan-dahir irfan-dahir deleted the fix/anime-sweeper branch October 1, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants