fix: remove process backend (#685)

* fix: remove process backend * fix: typo
jina-ai · Apr 20, 2022 · 71e9ebc · 71e9ebc
1 parent 65ad956
commit 71e9ebc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/docs/user-guides/server.md b/docs/user-guides/server.md
@@ -169,7 +169,6 @@ For PyTorch & ONNX backend, you can set the following parameters via `with`:
 | `name`    | Model weights, default is `ViT-B/32`. Support all OpenAI released pretrained models.                                           |
 | `num_worker_preprocess` | The number of CPU workers for image & text prerpocessing, default 4.                                                           | 
 | `minibatch_size` | The size of a minibatch for CPU preprocessing and GPU encoding, default 64. Reduce the size of it if you encounter OOM on GPU. |
-| `pool_backend` | The backend of the preprocessing worker pool, default is `thread`                                                               |
 
 There are also runtime-specific parameters listed below:
 

diff --git a/server/clip_server/executors/clip_onnx.py b/server/clip_server/executors/clip_onnx.py
@@ -29,18 +29,15 @@ def __init__(
         device: Optional[str] = None,
         num_worker_preprocess: int = 4,
         minibatch_size: int = 64,
-        pool_backend: str = 'thread',
         **kwargs,
     ):
         super().__init__(**kwargs)
         self.logger = JinaLogger(self.__class__.__name__)
 
         self._preprocess_blob = clip._transform_blob(_SIZE[name])
         self._preprocess_tensor = clip._transform_ndarray(_SIZE[name])
-        if pool_backend == 'thread':
-            self._pool = ThreadPool(processes=num_worker_preprocess)
-        else:
-            self._pool = Pool(processes=num_worker_preprocess)
+        self._pool = ThreadPool(processes=num_worker_preprocess)
+
         self._minibatch_size = minibatch_size
 
         self._model = CLIPOnnxModel(name)

diff --git a/server/clip_server/executors/clip_torch.py b/server/clip_server/executors/clip_torch.py
@@ -1,6 +1,6 @@
 import os
 import numpy as np
-from multiprocessing.pool import ThreadPool, Pool
+from multiprocessing.pool import ThreadPool
 from typing import Optional, List, Tuple
 
 from jina import Executor, requests, DocumentArray
@@ -17,7 +17,6 @@ def __init__(
         jit: bool = False,
         num_worker_preprocess: int = 4,
         minibatch_size: int = 64,
-        pool_backend: str = 'thread',
         **kwargs,
     ):
         super().__init__(**kwargs)
@@ -51,10 +50,7 @@ def __init__(
             name, device=self._device, jit=jit
         )
 
-        if pool_backend == 'thread':
-            self._pool = ThreadPool(processes=num_worker_preprocess)
-        else:
-            self._pool = Pool(processes=num_worker_preprocess)
+        self._pool = ThreadPool(processes=num_worker_preprocess)
 
     def _preproc_image(self, da: 'DocumentArray') -> 'DocumentArray':
         for d in da: