Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tracking): add scarf tracking #665

Merged
merged 1 commit into from
Mar 29, 2022
Merged

docs(tracking): add scarf tracking #665

merged 1 commit into from
Mar 29, 2022

Conversation

Roshanjossey
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #665 (d5cc638) into main (ae4d0ba) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files           2        2           
  Lines         100      100           
=======================================
  Hits           84       84           
  Misses         16       16           
Flag Coverage Δ
cas 84.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f8c40...d5cc638. Read the comment docs.

@numb3r3
Copy link
Member

numb3r3 commented Mar 29, 2022

For this PR, could you provide more context? I just found it is the first time we use Scarf in our projects. It is a toolchain for maintainers. Do we need to set up other components, e.g., some service, provider?

Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Note to other reviewers: scarf tracking gives us more granularity (e.g. company name) into who is reading our docs

Assigning whoever is head of this workstream to merge, since it's not my codebase

@numb3r3 numb3r3 merged commit cfaba71 into main Mar 29, 2022
@numb3r3 numb3r3 deleted the add-scarf-tracking branch March 29, 2022 08:28
samsja pushed a commit that referenced this pull request May 2, 2022
numb3r3 pushed a commit that referenced this pull request May 4, 2022
samsja pushed a commit that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants