Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitignore #673

Merged
merged 2 commits into from
Apr 6, 2022
Merged

feat: gitignore #673

merged 2 commits into from
Apr 6, 2022

Conversation

samsja
Copy link
Contributor

@samsja samsja commented Apr 5, 2022

Add the same gitignore as in jina core

@samsja samsja marked this pull request as draft April 5, 2022 13:31
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #673 (9064f2b) into main (257f039) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files           2        2           
  Lines         135      135           
=======================================
  Hits          118      118           
  Misses         17       17           
Flag Coverage Δ
cas 87.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b2ae8...9064f2b. Read the comment docs.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 marked this pull request as ready for review April 6, 2022 07:16
@numb3r3 numb3r3 merged commit ffc4bdc into main Apr 6, 2022
@numb3r3 numb3r3 deleted the feat-gitignore branch April 6, 2022 07:16
numb3r3 pushed a commit that referenced this pull request May 4, 2022
* feat: add gitignore

* fix: update black script to work on pr wo py files
samsja added a commit that referenced this pull request May 16, 2022
* feat: add gitignore

* fix: update black script to work on pr wo py files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants