Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ranker endpoint for all backends #707

Merged
merged 4 commits into from
May 4, 2022
Merged

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented May 4, 2022

TODO:

  • explain how to config logit_scale
    • from pre-trained model (same as torch implementation)
    • could be a static global variable or a parameter (this PR in onnx and tensorrt)

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #707 (d2dda01) into main (618dbdb) will increase coverage by 0.76%.
The diff coverage is 92.77%.

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   80.27%   81.03%   +0.76%     
==========================================
  Files          16       16              
  Lines        1100     1176      +76     
==========================================
+ Hits          883      953      +70     
- Misses        217      223       +6     
Flag Coverage Δ
cas 81.03% <92.77%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_trt.py 95.77% <92.10%> (-4.23%) ⬇️
server/clip_server/executors/clip_onnx.py 86.81% <93.02%> (+5.18%) ⬆️
server/clip_server/executors/clip_torch.py 87.01% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618dbdb...d2dda01. Read the comment docs.

@numb3r3 numb3r3 changed the title feat: add ranker endpoint for onnx feat: add ranker endpoint for all backends May 4, 2022
@numb3r3 numb3r3 merged commit f66b145 into main May 4, 2022
@numb3r3 numb3r3 deleted the feat-rerank-onnx branch May 4, 2022 17:34
diegofiori pushed a commit to diegofiori/clip-as-service that referenced this pull request May 12, 2022
* feat: add ranker endpoint for onnx

* fix: import

* feat: add ranker endpoint for trt

* fix: gpu test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant