Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cosine as the rank score #708

Merged
merged 7 commits into from
May 9, 2022
Merged

fix: use cosine as the rank score #708

merged 7 commits into from
May 9, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented May 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #708 (5bdfb2d) into main (f66b145) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   81.03%   81.24%   +0.20%     
==========================================
  Files          16       16              
  Lines        1176     1189      +13     
==========================================
+ Hits          953      966      +13     
  Misses        223      223
Flag Coverage Δ
cas 81.24% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/executors/clip_onnx.py 86.51% <100.00%> (-0.30%) ⬇️
server/clip_server/executors/clip_torch.py 88.09% <100.00%> (+1.08%) ⬆️
server/clip_server/executors/clip_trt.py 95.89% <100.00%> (+0.11%) ⬆️
server/clip_server/executors/helper.py 97.29% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706fa62...5bdfb2d. Read the comment docs.

@numb3r3 numb3r3 requested a review from hanxiao May 5, 2022 02:44
hanxiao
hanxiao requested changes May 5, 2022
View reviewed changes
Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait official implementation says differently

hanxiao
hanxiao reviewed May 7, 2022
View reviewed changes
tests/test_ranker.py Outdated Show resolved Hide resolved
@numb3r3 numb3r3 requested a review from hanxiao May 8, 2022 09:00
@numb3r3 numb3r3 merged commit 835eb13 into main May 9, 2022
@numb3r3 numb3r3 deleted the fix-logits branch May 9, 2022 02:08
diegofiori pushed a commit to diegofiori/clip-as-service that referenced this pull request May 12, 2022
@numb3r3
fix: use cosine as the rank score (jina-ai#708)
7014fb4 
* fix: use cosine as the rank score

* fix: return cosine or probls as rank score

* fix: add logit scale

* fix: unittest

* fix: use softmax as para name

* fix: return both softmax and cosine

* fix: numpy softmax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/testing component/server size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@numb3r3 @hanxiao