Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep logit_scale on same device #710

Merged
merged 2 commits into from
May 9, 2022
Merged

fix: keep logit_scale on same device #710

merged 2 commits into from
May 9, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented May 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #710 (592dbb5) into main (835eb13) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files          16       16           
  Lines        1189     1189           
=======================================
  Hits          966      966           
  Misses        223      223           
Flag Coverage Δ
cas 81.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/executors/clip_torch.py 88.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099e221...592dbb5. Read the comment docs.

@numb3r3 numb3r3 changed the title fix: keep logit_scale on cpu fix: keep logit_scale on same device May 9, 2022
@numb3r3 numb3r3 merged commit bb520d1 into main May 9, 2022
@numb3r3 numb3r3 deleted the fix-logit-device branch May 9, 2022 10:22
diegofiori pushed a commit to diegofiori/clip-as-service that referenced this pull request May 12, 2022
* fix: keep logit_scale on cpu

* fix: use cuda when computing ranked score
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant