Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows file name conflict #729

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: windows file name conflict #729

merged 2 commits into from
May 25, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented May 24, 2022

No description provided.

@ZiniuYu ZiniuYu requested a review from numb3r3 May 24, 2022 10:48
@ZiniuYu ZiniuYu linked an issue May 24, 2022 that may be closed by this pull request
Some file names not compatible with Windows #720
Closed
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #729 (a384c44) into main (0054b47) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files          16       16           
  Lines        1137     1137           
=======================================
  Hits          916      916           
  Misses        221      221
Flag Coverage Δ
cas 80.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7323d99...a384c44. Read the comment docs.

numb3r3
numb3r3 requested changes May 24, 2022
View reviewed changes
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean all of the unused PNG files

@ZiniuYu ZiniuYu requested a review from numb3r3 May 25, 2022 07:11
numb3r3
numb3r3 approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@numb3r3 numb3r3 merged commit 59f48e6 into main May 25, 2022
@numb3r3 numb3r3 deleted the fix-windows-filename branch May 25, 2022 07:58
@hanxiao hanxiao mentioned this pull request May 25, 2022
Merged
hanxiao added a commit that referenced this pull request May 25, 2022
@hanxiao
Revert "fix: windows file name conflict (#729)"
e6633e3 
This reverts commit 59f48e6.
hanxiao added a commit that referenced this pull request May 25, 2022
@hanxiao
Revert "fix: windows file name conflict (#729)" (#730)
e1acf9a 
This reverts commit 59f48e6.
@ZiniuYu ZiniuYu restored the fix-windows-filename branch May 26, 2022 02:42
@ZiniuYu ZiniuYu deleted the fix-windows-filename branch June 13, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numb3r3 numb3r3 numb3r3 approved these changes

Assignees
No one assigned
Labels
area/housekeeping size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some file names not compatible with Windows
2 participants
@ZiniuYu @numb3r3