-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better monitoring #738
Conversation
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
===========================================
- Coverage 80.91% 66.69% -14.23%
===========================================
Files 16 16
Lines 1153 1171 +18
===========================================
- Hits 933 781 -152
- Misses 220 390 +170
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mention in the documentation https://docs.jina.ai/fundamentals/executor/monitoring-executor/#defining-custom-metrics-with-monitor
To respect prometheus naming convention we need to add seconds
at the end of the metrics
@samsja Thanks for suggestions, have addressed them |
Does not make sense to enable monitoring default, will remove monitoring from default YAML config. The monitoring port should be provided by the user depending on their environment in production.