fix: fix client concurrent issue #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 80.41% 81.78% +1.37%
==========================================
Files 17 17
Lines 1205 1208 +3
==========================================
+ Hits 969 988 +19
+ Misses 236 220 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
numb3r3
requested changes
Jun 13, 2022
numb3r3
requested changes
Jun 13, 2022
client/clip_client/client.py
Outdated
|
|
||
| def _gather_result(self, r): | ||
| def _gather_result(self, r, results): |
There was a problem hiding this comment.
Suggested change
| def _gather_result(self, r, results): | |
| def _gather_result(self, response, results: 'DocumentArray'): |
client/clip_client/client.py
Outdated
| def _unboxed_result(self): | ||
| if self._results.embeddings is None: | ||
| @staticmethod | ||
| def _unboxed_result(results, return_plain): |
There was a problem hiding this comment.
Suggested change
| def _unboxed_result(results, return_plain): | |
| def _unboxed_result(results, return_plain: bool): |
ZiniuYu
force-pushed
the
fix-client-concurrent
branch
from
498e41f to
c838520
Compare
numb3r3
requested changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original client implementation, it uses a global result variable to store all results from the server. This may break with the async client in that it can not distinguish the source of input and thus mix all concurrent requests and return the wrong results.
This PR fixes the above issue.