-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow credential in client #765
Conversation
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 82.09% 81.85% -0.25%
==========================================
Files 17 17
Lines 1240 1251 +11
==========================================
+ Hits 1018 1024 +6
- Misses 222 227 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks fine so far. But I will block this PR until we have a solid integration test ready.
08e2900
to
50e6901
Compare
This pr allow users to pass credential for HTTP and GRPC, and use it for authentication when getting request from server