Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow credential in client #765

Merged
merged 9 commits into from
Jul 20, 2022
Merged

feat: allow credential in client #765

merged 9 commits into from
Jul 20, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Jul 12, 2022

This pr allow users to pass credential for HTTP and GRPC, and use it for authentication when getting request from server

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #765 (50e6901) into main (2b78b12) will decrease coverage by 0.24%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   82.09%   81.85%   -0.25%     
==========================================
  Files          17       17              
  Lines        1240     1251      +11     
==========================================
+ Hits         1018     1024       +6     
- Misses        222      227       +5     
Flag Coverage Δ
cas 81.85% <65.21%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/client.py 86.38% <65.21%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca03dca...50e6901. Read the comment docs.

client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/helper.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/helper.py Outdated Show resolved Hide resolved
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine so far. But I will block this PR until we have a solid integration test ready.

client/clip_client/client.py Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu force-pushed the client_credential branch from 08e2900 to 50e6901 Compare July 20, 2022 03:39
@numb3r3 numb3r3 marked this pull request as ready for review July 20, 2022 05:16
@numb3r3 numb3r3 closed this Jul 20, 2022
@numb3r3 numb3r3 reopened this Jul 20, 2022
@numb3r3 numb3r3 merged commit 0ff4e25 into main Jul 20, 2022
@numb3r3 numb3r3 deleted the client_credential branch July 20, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants