-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow model selection in client #775
Conversation
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 81.85% 81.91% +0.05%
==========================================
Files 17 17
Lines 1251 1255 +4
==========================================
+ Hits 1024 1028 +4
Misses 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
client/clip_client/client.py
Outdated
payload = dict( | ||
on='/', | ||
on=endpoint, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on=endpoint, | |
on=f'/encode/{model_name}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we introducing extra '/'?
📝 Docs are deployed on https://ft-client_model_select--jina-docs.netlify.app 🎉 |
21cce4b
to
fd25e96
Compare
This pr allows the user to select the model in the client when multiple models are running.
Sample usage: