feat: do not send blob from server when it is loaded in client #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numb3r3
requested changes
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 81.52% 84.10% +2.57%
==========================================
Files 21 21
Lines 1440 1466 +26
==========================================
+ Hits 1174 1233 +59
+ Misses 266 233 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
numb3r3
requested changes
Aug 11, 2022
ZiniuYu
force-pushed
the
no-blob-from-server
branch
from
6edbfde to
4d61e28
Compare
numb3r3
reviewed
Aug 12, 2022
client/clip_client/client.py
Outdated
| @@ -119,6 +121,11 @@ def encode(self, content, **kwargs): | |||
| **self._get_post_payload(content, kwargs), | |||
| on_done=partial(self._gather_result, results=results), | |||
| ) | |||
|
|
|||
| for c in content: | |||
| if isinstance(c, Document) and c.tags.pop('__loaded_by_CAS__', False): | |||
There was a problem hiding this comment.
Suggested change
| if isinstance(c, Document) and c.tags.pop('__loaded_by_CAS__', False): | |
| if hasattr(c, 'tags') and c.tags.pop('__loaded_by_CAS__', False): |
There was a problem hiding this comment.
The benefits from change above:
- reduce the memory footprint (to address OOM when processing a large number of documents);
- keep the inputs not updated;
There was a problem hiding this comment.
The future better way is to support in-place update in encode(docs)
numb3r3
requested changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user encodes a document with uri and no blob, the current implementation will load the blob in the client and send it to the server.
This pr saves the bandwidth by not sending back blob from the server
I ran some tests to see the benefit we have from this change.
Server config: default minibatch_size=32, model: Vit-L/14@336px, replicas: 3
Client config: default batch_size=8, input DocumentArray size=80 with each Document having a URI of an image of size ~1.5MB
Before: send 90MB, recv 90MB, cost 3-13min (Server hosted on Beijing GPU 3-7min/Berlin GPU 6-13min)
After: send 90MB, recv 250KB, cost 1-3min
In general, the time varies because of remote network communications, but the recv package sizes substantially drops