Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve model not found error msg #812

Merged
merged 3 commits into from
Aug 31, 2022
Merged

chore: improve model not found error msg #812

merged 3 commits into from
Aug 31, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Aug 31, 2022

We did not list all available models when the user input a wrong model name in torch runtime previously, this pr fix this
this pr also reformat the error msg, it now looks like

image

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #812 (78a75a7) into main (ea23968) will increase coverage by 2.25%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   81.65%   83.90%   +2.25%     
==========================================
  Files          21       21              
  Lines        1466     1466              
==========================================
+ Hits         1197     1230      +33     
+ Misses        269      236      -33     
Flag Coverage Δ
cas 83.90% <66.66%> (+2.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/clip_model.py 87.50% <0.00%> (ø)
server/clip_server/model/clip_onnx.py 82.22% <ø> (ø)
server/clip_server/model/clip_trt.py 85.71% <ø> (+16.32%) ⬆️
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/model/trt_utils.py 83.51% <0.00%> (+27.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens on other backend, ONNX and TensorRT

@ZiniuYu
Copy link
Member Author

ZiniuYu commented Aug 31, 2022

What happens on other backend, ONNX and TensorRT

the are fine

server/clip_server/model/clip_model.py Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu changed the title chore: update model not found error msg in torch runtime chore: improve model not found error msg Aug 31, 2022
@github-actions github-actions bot added size/s and removed size/xs labels Aug 31, 2022
@ZiniuYu ZiniuYu requested a review from a team August 31, 2022 07:51
@ZiniuYu
Copy link
Member Author

ZiniuYu commented Aug 31, 2022

@numb3r3 I tried to use f'' strs but python doesn't allow to put backslashes in it, so I have to '{}'.format() instead

@ZiniuYu ZiniuYu merged commit f7ee26a into main Aug 31, 2022
@ZiniuYu ZiniuYu deleted the torch-model-errmsg branch August 31, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants