Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop image content to boost latency #824

Merged
merged 9 commits into from
Sep 19, 2022
Merged

feat: drop image content to boost latency #824

merged 9 commits into from
Sep 19, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented Sep 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #824 (c34c4ba) into main (bcce990) will decrease coverage by 2.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   84.67%   82.56%   -2.12%     
==========================================
  Files          21       21              
  Lines        1573     1566       -7     
==========================================
- Hits         1332     1293      -39     
- Misses        241      273      +32     
Flag Coverage Δ
cas 82.56% <100.00%> (-2.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/client.py 88.78% <100.00%> (-0.25%) ⬇️
server/clip_server/executors/clip_onnx.py 84.72% <100.00%> (+0.66%) ⬆️
server/clip_server/executors/clip_tensorrt.py 93.10% <100.00%> (+0.37%) ⬆️
server/clip_server/executors/clip_torch.py 83.33% <100.00%> (+0.79%) ⬆️
server/clip_server/executors/helper.py 97.05% <100.00%> (ø)
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member Author

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZiniuYu Please address the comments.

client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
client/clip_client/client.py Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu requested a review from a team September 19, 2022 06:54
@numb3r3 numb3r3 merged commit c690c24 into main Sep 19, 2022
@numb3r3 numb3r3 deleted the fix-drop-content branch September 19, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants