-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support large ONNX model files #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 82.57% 84.38% +1.80%
==========================================
Files 21 21
Lines 1567 1575 +8
==========================================
+ Hits 1294 1329 +35
+ Misses 273 246 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZiniuYu
changed the title
feat: support not yet supported onnx models
feat: support large ONNX model files
Sep 23, 2022
numb3r3
requested changes
Sep 23, 2022
jemmyshin
reviewed
Sep 23, 2022
numb3r3
requested changes
Sep 23, 2022
📝 Docs are deployed on https://ft-zip-model--jina-docs.netlify.app 🎉 |
numb3r3
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE Please merge #825 first!!!
This PR supports the following ONNX models:
This is accomplished by rewriting the loading logic: if the model file is a zip file, we unzip it to a tmp dir and load the model from there.
This PR also rewrites loading M-CLIP logic: the visual model now loads from our custom open-clip models