Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix configuration file for the search flow #869

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

zawabest
Copy link
Contributor

@zawabest zawabest commented Dec 1, 2022

del null key.
otherwise,U will get this error.
TypeError: clip_server.executors.clip_torch.CLIPEncoder() argument after ** must be a mapping, not NoneType.

@jemmyshin
Copy link
Contributor

Thanks for reporting, we will fix this soon

@jemmyshin
Copy link
Contributor

jemmyshin commented Dec 1, 2022

can you fix the commit message checking error by removing the dot? It complains: subject may not end with full stop @zawabest

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #869 (a5e9c55) into main (f251539) will decrease coverage by 11.87%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #869       +/-   ##
===========================================
- Coverage   82.66%   70.78%   -11.88%     
===========================================
  Files          22       22               
  Lines        1448     1448               
===========================================
- Hits         1197     1025      -172     
- Misses        251      423      +172     
Flag Coverage Δ
cas 70.78% <ø> (-11.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-93.11%) ⬇️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-85.72%) ⬇️
server/clip_server/model/trt_utils.py 0.00% <0.00%> (-83.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zawabest zawabest changed the title chore: fix configuration file for the search flow. chore: fix configuration file for the search flow Dec 1, 2022
@zawabest
Copy link
Contributor Author

zawabest commented Dec 1, 2022

can you fix the commit message checking error by removing the dot? It complains: subject may not end with full stop @zawabest

done

Copy link
Member

@ZiniuYu ZiniuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ZiniuYu ZiniuYu merged commit c7af9f7 into jina-ai:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants