Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cn clip model #888

Merged
merged 14 commits into from
Feb 9, 2023
Merged

feat: add cn clip model #888

merged 14 commits into from
Feb 9, 2023

Conversation

Hippopotamus0308
Copy link
Contributor

@Hippopotamus0308 Hippopotamus0308 commented Jan 12, 2023

Using cn clip model from https://github.com/OFA-Sys/Chinese-CLIP

Namely,

  • CN-CLIP/ViT-B-16
  • CN-CLIP/ViT-L-14
  • CN-CLIP/ViT-L-14-336
  • CN-CLIP/ViT-H-14
  • CN-CLIP/RN50

server/setup.py Outdated Show resolved Hide resolved
@ZiniuYu
Copy link
Member

ZiniuYu commented Jan 12, 2023

@Hippopotamus0308 lint failed, please check your commit messages (including pr title) 🙇

@Hippopotamus0308 Hippopotamus0308 changed the title Feat: add cn clip model feat: add cn clip model Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #888 (f4dce2b) into main (8a576c5) will decrease coverage by 11.48%.
The diff coverage is 68.42%.

@@             Coverage Diff             @@
##             main     #888       +/-   ##
===========================================
- Coverage   83.08%   71.60%   -11.49%     
===========================================
  Files          22       23        +1     
  Lines        1531     1567       +36     
===========================================
- Hits         1272     1122      -150     
- Misses        259      445      +186     
Flag Coverage Δ
cas 71.60% <68.42%> (-11.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/tokenization.py 74.41% <41.66%> (-13.47%) ⬇️
server/clip_server/model/cnclip_model.py 77.27% <77.27%> (ø)
server/clip_server/model/clip_model.py 92.59% <100.00%> (+0.92%) ⬆️
server/clip_server/model/pretrained_models.py 98.43% <100.00%> (+0.02%) ⬆️
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-94.60%) ⬇️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-85.72%) ⬇️
server/clip_server/model/trt_utils.py 0.00% <0.00%> (-83.52%) ⬇️
server/clip_server/model/clip_onnx.py 87.30% <0.00%> (+22.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/m and removed size/s labels Jan 12, 2023
Copy link
Contributor

@jemmyshin jemmyshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit dabbe8b into main Feb 9, 2023
@numb3r3 numb3r3 deleted the feat-cn-clip branch February 9, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants