feat: set prefetch in client for traffic control #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
===========================================
- Coverage 82.70% 71.61% -11.10%
===========================================
Files 23 23
Lines 1567 1564 -3
===========================================
- Hits 1296 1120 -176
- Misses 271 444 +173
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZiniuYu
changed the title
|
Could you give an example of the new progress bar after this PR? |
numb3r3
requested changes
Mar 3, 2023
girishc13
reviewed
Mar 3, 2023
| @@ -334,6 +341,7 @@ def encode(self, content, **kwargs): | |||
| on_error=on_error, | |||
| on_always=partial(self._update_pbar, func=on_always), | |||
| parameters=parameters, | |||
| prefetch=prefetch, | |||
There was a problem hiding this comment.
You can just inline the code like: prefecth=kwargs.get('prefetch', 1000). You can reduce the number of lines if you do this to other params also.
|
@ZiniuYu From the example bar, I would suggest changing |
|
📝 Docs are deployed on https://ft-fix-client-prefetch--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we introduce the prefetch in client for traffic control.
This is especially beneficial to large and time consuming requests which can be unexpectedly be closed be remote server and cause timeout watchdog issue.
This PR also disables uploading progress bar that is not compatible with prefetching 🙁
For more info about client prefetching, please view https://docs.jina.ai/concepts/client/rate-limit/