Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace transform ndarray with transform blob #910

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Apr 12, 2023

No description provided.

@ZiniuYu ZiniuYu linked an issue Apr 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #910 (164765e) into main (1888ef6) will decrease coverage by 11.13%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##             main     #910       +/-   ##
===========================================
- Coverage   82.73%   71.61%   -11.13%     
===========================================
  Files          23       23               
  Lines        1564     1564               
===========================================
- Hits         1294     1120      -174     
- Misses        270      444      +174     
Flag Coverage Δ
cas 71.61% <87.50%> (-11.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-94.60%) ⬇️
server/clip_server/executors/clip_onnx.py 86.81% <100.00%> (ø)
server/clip_server/executors/clip_torch.py 87.77% <100.00%> (ø)
server/clip_server/executors/helper.py 97.18% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZiniuYu ZiniuYu requested a review from a team April 12, 2023 11:32
@ZiniuYu ZiniuYu marked this pull request as ready for review April 13, 2023 02:37
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 35733a0 into main Apr 14, 2023
@numb3r3 numb3r3 deleted the fix-transform-blob branch April 14, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_transform_ndarray vs _transform_blob
2 participants