Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docarray at v1 #911

Merged
merged 5 commits into from
Apr 19, 2023
Merged

fix: fix docarray at v1 #911

merged 5 commits into from
Apr 19, 2023

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Apr 19, 2023

This PR aims to prevent the installation of DocArrayV2, as we have encountered some compatibility issues that require further investigation. While this solution is temporary, it will allow us to ensure that our codebase remains stable and free from potential conflicts.

After conducting a thorough investigation of the compatibility of DocArrayV2, we will determine the best course of action moving forward. Until then, we appreciate your patience and understanding as we work to maintain the integrity of our codebase.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #911 (33c300d) into main (35733a0) will decrease coverage by 11.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #911       +/-   ##
===========================================
- Coverage   82.73%   71.61%   -11.13%     
===========================================
  Files          23       23               
  Lines        1564     1564               
===========================================
- Hits         1294     1120      -174     
- Misses        270      444      +174     
Flag Coverage Δ
cas 71.61% <ø> (-11.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@numb3r3 numb3r3 merged commit 280b925 into main Apr 19, 2023
@numb3r3 numb3r3 deleted the fix-docarray-v1 branch April 19, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants