-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a decoratator for monitoring method #4737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4737 +/- ##
==========================================
- Coverage 87.73% 87.65% -0.09%
==========================================
Files 119 119
Lines 8661 8690 +29
==========================================
+ Hits 7599 7617 +18
- Misses 1062 1073 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
9b2689d
to
58ba316
Compare
03d997a
to
38c7821
Compare
This reverts commit 3ff8656.
38c7821
to
314f359
Compare
Co-authored-by: Joan Fontanals <[email protected]>
|
'metric_name' is the name that will appear on prometheus. For example if you are monitoring the time that clip as a service spend processing some text you will call it |
for point 2. you are right I will update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing unit tests for the monitor decorator
done |
Follow up of jina-ai/clip-as-service#674
Goal:
Having an decorator to monitor internal method of an Executor