-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: raise exceptions in path importer #5447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5447 +/- ##
==========================================
+ Coverage 87.31% 87.33% +0.01%
==========================================
Files 101 101
Lines 6613 6615 +2
==========================================
+ Hits 5774 5777 +3
+ Misses 839 838 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Goals:
Currently, we add all paths into
not_python_module_paths
but sometimes the exception comes from ImportError(or other types of error). So we need to raise this exception to make the error message clear.resolves clip-as-service issue #865
check and update documentation. See guide and ask the team.