Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise exceptions in path importer #5447

Merged
merged 13 commits into from
Nov 25, 2022
Merged

fix: raise exceptions in path importer #5447

merged 13 commits into from
Nov 25, 2022

Conversation

jemmyshin
Copy link
Contributor

@jemmyshin jemmyshin commented Nov 25, 2022

Goals:
Currently, we add all paths into not_python_module_paths but sometimes the exception comes from ImportError(or other types of error). So we need to raise this exception to make the error message clear.

  • resolves clip-as-service issue #865

  • check and update documentation. See guide and ask the team.

@jemmyshin jemmyshin requested review from numb3r3 and JoanFM November 25, 2022 05:07
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing labels Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #5447 (4dcffab) into master (0db2d18) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #5447      +/-   ##
==========================================
+ Coverage   87.31%   87.33%   +0.01%     
==========================================
  Files         101      101              
  Lines        6613     6615       +2     
==========================================
+ Hits         5774     5777       +3     
+ Misses        839      838       -1     
Flag Coverage Δ
jina 87.33% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/importer.py 87.20% <33.33%> (-2.08%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 98.13% <0.00%> (+2.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 25, 2022
tests/unit/test_importer.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tests/unit/test_importer.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 25, 2022
JoanFM
JoanFM previously approved these changes Nov 25, 2022
tests/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanFM JoanFM merged commit 6e0222f into master Nov 25, 2022
@JoanFM JoanFM deleted the fix-import-error branch November 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants