Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not assign results if Exception #6128

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 14, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (129b7b3) 73.01% compared to head (25a0de4) 75.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6128      +/-   ##
==========================================
+ Coverage   73.01%   75.19%   +2.18%     
==========================================
  Files         152      152              
  Lines       14062    14059       -3     
==========================================
+ Hits        10267    10572     +305     
+ Misses       3795     3487     -308     
Flag Coverage Δ
jina 75.19% <100.00%> (+2.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Dec 14, 2023
@JoanFM JoanFM force-pushed the fix-exception-dynamic-batching branch 3 times, most recently from d5813b6 to 48e7a60 Compare December 14, 2023 10:21
@JoanFM JoanFM force-pushed the fix-exception-dynamic-batching branch from 48e7a60 to 25a0de4 Compare December 14, 2023 10:38
@JoanFM JoanFM merged commit 48e4437 into master Dec 14, 2023
130 of 131 checks passed
@JoanFM JoanFM deleted the fix-exception-dynamic-batching branch December 14, 2023 11:10
@JoanFM JoanFM mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant