Minor cleanup of DescendantRebaser #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-rrykxwzoomys
branch
from
b3444b8 to
810e555
Compare
The `rebase_next()` method is private, so I think we've addressed the TODO.
`rebase_next()` returns an `Option<RebasedDescendant>`, but the only way we use it is to decide whether to terminate the loop over `to_visit`. Let's simplify by making the caller iterate over `to_visit` instead.
martinvonz
force-pushed
the
push-rrykxwzoomys
branch
from
810e555 to
8f40566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing #2901 made me decide to send these commits I wrote a few days ago before they go stale. It doesn't look like anything conflicts with that PR. FYI, I'm working on #2600 a little bit here and there. I guess I should assign that to myself. I'll do that.
Checklist
If applicable:
CHANGELOG.md