Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: more informative intro sentence #14

Merged
merged 4 commits into from
Jan 17, 2021

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Jan 16, 2021

Also add links to the pre-announcement Discourse post/thread and to the alternative tools (Pipe.jl and Lazy.jl), and unwrap the only line that was hard-wrapped in the document.

Also link to the pre-announcement Discourse post/thread,
and unwrap the only line that was hard-wrapped in the document.
Copy link
Owner

@jkrumbiegel jkrumbiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvements!

README.md Outdated
@@ -89,6 +90,8 @@ This is very useful to inspect pipeline state during debugging, for example.
- Because everything is just lines with separate expressions and not one huge function call, IDEs can show exactly in which line errors happened
- Pipe is a name defined by Base Julia which can lead to conflicts

For more details, see the [pre-announcement post](https://discourse.julialang.org/t/rfc-pipelesspipes-jl-now-chain-jl/50448).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this is necessary, the readme has all the information needed and that thread was mostly about deciding the last details

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can remove it. I personally find it interesting to be able to follow the early history of projects, but I understand it can add more noise than actual useful information.

README.md Outdated
@@ -1,6 +1,6 @@
# Chain.jl

Even more convenient than pipes.
A [Julia package](https://julialang.org/packages/) for chaining function calls using a more convenient syntax than Julia's native [piping functionality](https://docs.julialang.org/en/v1/manual/functions/#Function-composition-and-piping).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really for chaining function calls, more for piping a value through a series of transformation expressions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction :) I've applied this change.

@jkrumbiegel jkrumbiegel merged commit 5d6f3fa into jkrumbiegel:master Jan 17, 2021
@waldyrious waldyrious deleted the patch-1 branch January 17, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants