Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove filter #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

matthieugomez
Copy link

@matthieugomez matthieugomez commented Apr 26, 2021

subset is preferred to filter in DataFrames 1.0, so I used lm as an example of using dataframe as a second argument.

`subset` is preferred to `filter` in DataFrames 1.0. Use `lm` as an example of dataframe as a second argument.
@jkrumbiegel
Copy link
Owner

Thanks, that might be a good idea to change. I think I tweaked the examples before to fit into the column width on github without horizontal scrolling, could be that this doesn't fit anymore with lm. I'm also not sure if I find that function a bit too specialized, don't know how widely used it is. But it is a good example of needing a second argument. What other functions would offer themselves instead of filter?

@matthieugomez
Copy link
Author

matthieugomez commented Apr 28, 2021

Ok, we can use CSV.write

replace lm by CSV.write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants