Let filters to be set before running reports #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Why is this not yet merged into current version? |
|
I tested this with current version of the plugin (2024051300, released November 6th 2024. in Moodle plugins directory). Everything works correctly except export. Export to XLS format exports empty workbook, although there are records in the report displayed on the screen in Moodle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help to mitigate the issue #146 with heavy reports that are taking long to execute when filters are not set.
For instance, you have a report that scans log table or does heavy joins and you don't really want to run the report without filters as it would take ages to complete while with filters set it is pretty quick and good enough to be used.
Currently, users have to wait for the report to load with empty filters, then they set filters and run the report again.
The idea of this enhancement is to prevent the report from executing if filters are configured, but not set. When users access reports with added filters they can see Apply filters to run the report message under the filter form. Then they can set the filters and click Apply button to run the report.