Skip to content

Commit

Permalink
Fix merge conflicts
Browse files Browse the repository at this point in the history
Merge branch 'hnsw0.8.0' of https://github.com/jlmelville/rcpphnsw into hnsw0.8.0

# Conflicts:
#	cran-comments.md
  • Loading branch information
jlmelville committed Feb 4, 2024
2 parents efccad2 + 71e5b34 commit f1b950e
Showing 1 changed file with 14 additions and 32 deletions.
46 changes: 14 additions & 32 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,60 +1,42 @@
## Release Summary

This is a patch release to fix various CRAN check errors.
This is a patch release for a new version of the underlying hnswlib library.

## Test environments

* ubuntu 22.04 (on github actions), R 4.2.3, R 4.3.1, devel
* local ubuntu 23.04 R 4.2.2
* ubuntu 22.04 (on github actions), R 4.2.3, R 4.3.2, devel
* local ubuntu 23.10 R 4.3.1
* Debian Linux, R-devel, GCC ASAN/UBSAN (via rhub)
* Debian Linux, R-release, GCC (via rhub)
* Debian Linux, R-release, GCC valgrind (via rhub)
* Ubuntu Linux 20.04.1 LTS, R-release, GCC (via rhub)
* Fedora Linux, R-devel, clang, gfortran (via rhub)
* Windows Server 2022 (on github actions), R 4.2.3, R 4.3.1
* Windows Server 2022 (on github actions), R 4.2.3, R 4.3.2
* Windows Server 2022, R-devel, 64 bit (via rhub)
* local Windows 11 build, R 4.3.1
* local Windows 11 build, R 4.3.2
* win-builder (devel)
* mac OS X Monterey (on github actions) R 4.3.1
* local mac OS X Sonoma R 4.3.2
* mac OS X Monterey (on github actions) R 4.3.2

## R CMD check results

There were no ERRORs or WARNINGs.

There was one NOTE:

N checking installed package size ...
installed size is 6.6Mb
sub-directories of 1Mb or more:
libs 6.3Mb
* checking installed package size ... NOTE
installed size is 6.7Mb
sub-directories of 1Mb or more:
libs 6.4Mb

This is expected due to the use of C++ templates in hnswlib.

This is spelled correctly.

## CRAN checks

There are no ERRORs or WARNINGs.

There is a NOTE:

Check: C++ specification
Result: NOTE
Specified C++11: please drop specification unless essential

This submission fixes this.

There is a NOTE:

Check: Rd metadata
Result: NOTE
Invalid package aliases in Rd file ‘RcppHnsw-package.Rd’:
‘RcppHnsw-package’

This submissions fixes this.

There are four flavors with NOTEs about installed package size (r-release-macos-arm64,
r-release-macos-x86_64, r-oldrel-macos-arm64, r-oldrel-macos-x86_64). This is expected and won't be
fixed.
There are three flavors with NOTEs about installed package size (r-release-macos-arm64,
r-release-macos-x86_64, r-oldrel-macos-arm64). This is expected and won't be fixed.

## Downstream dependencies

Expand Down

0 comments on commit f1b950e

Please sign in to comment.