Skip to content

Commit

Permalink
Update CRAN comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
jlmelville committed Nov 15, 2020
1 parent ea78a35 commit 63c8a63
Showing 1 changed file with 23 additions and 43 deletions.
66 changes: 23 additions & 43 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,54 +1,43 @@
## Resubmission
## New Release

This is a resubmission. In this version I have:
This is a new release to:

* Resolved usages of dependencies that resulted in UBSAN errors.
* Changed a default argument which caused an example error in a downstream
dependency.
* Make internal changes to maintain compatibility with a forthcoming release of
a dependency (RcppAnnoy).
* Make a minor license change: previous versions of uwot were licensed under
GPL-3. This submission changes the license to GPL-3 or later.
* Offer some minor new functionality.

## Test environments

* ubuntu 16.04 (on travis-ci), R 3.5.3, R 3.6.2, R-devel
* ubuntu 16.04 (on travis-ci), R 3.6.3, R 4.0.2, R-devel
* ubuntu 16.04 (on rhub), R 3.6.1
* fedora 31 (on rhub), R-devel
* mac OS X High Sierra (on travis-ci), R 3.5.3, R 3.6.2
* local Windows 10 build, R 3.6.2, R 3.6.3
* local Pop OS (Linux) build R 3.6.3
* Windows Server 2008 (on rhub) R-devel
* Windows Server 2012 (on appveyor) R 3.6.2
* mac OS X High Sierra (on travis-ci), R 3.6.3, R 4.0.3
* local Windows 10 build, R 4.0.3
* Windows Server 2012 (on appveyor) R 4.0.3
* win-builder (devel)

## R CMD check results

There were no ERRORs or WARNINGs.

* For r-hub with Windows Server 2008 R2 SP1, R-devel, 32/64 bit there was one
NOTE:

```
checking for non-standard things in the check directory ... NOTE
'examples_i386' 'examples_x64' 'tests_i386' 'tests_x64'
Found the following files/directories:
'uwot-Ex_i386.Rout' 'uwot-Ex_x64.Rout'
```

This would seem to be something to do with r-hub rather than a real problem.

* For r-hub with Ubuntu Linux 16.04 LTS, R-release, GCC there was one NOTE:

```
* checking installed package size ... NOTE
installed size is 6.4Mb
installed size is 6.9Mb
sub-directories of 1Mb or more:
libs 6.0Mb
libs 6.5Mb
```

* For r-hub with Fedora Linux, R-devel, clang, gfortran there was a similar NOTE:

```
* checking installed package size ... NOTE
installed size is 5.0Mb
installed size is 5.8Mb
sub-directories of 1Mb or more:
libs 4.5Mb
libs 5.5Mb
```

This is due to the underlying C++ implementation using templates.
Expand All @@ -66,23 +55,14 @@ These are spelled correctly.

## CRAN checks

The following issues were reported in the previous submission:

* r-patched-solaris-x86 had an ERROR, because the RcppAnnoy package was
unavailable.

* A gcc-UBSAN issue was reported due to libraries used by RcppAnnoy and
RcppParallel.

Both should now be fixed.
There are no WARNINGs or ERRORs.

## Downstream dependencies

There are 5 downstream CRAN dependencies and 3 Bioconductor dependencies:
There are 8 downstream CRAN dependencies and 16 Bioconductor dependencies:

* Five of these packages report either NOTEs or a mixture of WARNINGs and NOTEs.
None are related to 'uwot'.
* The other three dependencies completed R CMD CHECK without issues.
* The previous submission caused an error in an example in the iCellR package.
This submission and changes in the latest version of iCellR have resolved this
error.
* There is no change to the number of, or type of ERRORs, WARNINGs, or NOTEs
generated by these packages with the current version of uwot, compared to the
new submission.
* None of the existing ERRORs, WARNINGs or NOTEs generated by the downstream
dependencies are related to uwot.

0 comments on commit 63c8a63

Please sign in to comment.