Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umap_transform does not validate input sufficiently #76

Open
jlmelville opened this issue Jun 27, 2021 · 2 comments
Open

umap_transform does not validate input sufficiently #76

jlmelville opened this issue Jun 27, 2021 · 2 comments

Comments

@jlmelville
Copy link
Owner

See satijalab/seurat#4647 for an example.

@teunbrand
Copy link

If it is helpful in any way, if prod(dim(X)) < 1, I can crash the R session consistently.
I think it would be great if an error message pops up in this case instead of a session crash.

# Note: code crashes session. Execute with caution.
library(uwot)

model <- umap(iris, ret_model = TRUE)
trans <- umap_transform(iris[0, ], model = model)

@jlmelville
Copy link
Owner Author

Thank you @teunbrand. The current version on github doesn't cause a session crash with this code, but the error message isn't very good so there is room for improvement here.

jlmelville added a commit that referenced this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants