Make the null value customizable [wip] #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've disabled two the introspection test case in the dungeon: The introspection schema needs some modifications to make this work. I the assertions to check for the custom null value of 'owl'; this should prove that it is possible to set the null value to any atom.
|
Nice! Can I get you to rebase this on top of the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the null value customisable, so we can support systems that use a different from 'null' value as its concept of null; systems such as Elixir, and perhaps protobuf.
So far I've carried the context through to the paths that seems to be relevant; the context now carry a key called
null_valuethat eventually will be a configuration option. I've changed thenullvalue toowl; it doesn't really make sense besides testing that a different atom can be used—the plan is to switch this tonullwhen it has proved its point so we can get this into the system without causing too much trouble.It should be said: I don't know much about this part of the code, so my approach has been poking around, adding log messages, and changing values…it seems to work for the most part (as of writing there is still some null values being propagated), but I am not sure it is the correct approach.
Work in progress—at least I know more about the
graphql-execution-module than I did before.