Make TestWallet derive from CWallet #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
commented
May 20, 2022
| TransactionInProcess aliceToCharlie = alice->CreateSpendTransaction(charlie, 10000, 5000, useThisTransaction); | ||
| CValidationState state; | ||
| EXPECT_FALSE(alice->CommitTransaction(aliceToCharlie.transaction, aliceToCharlie.reserveKey, state)); | ||
| EXPECT_EQ(state.GetRejectReason(), "mempool conflict"); |
There was a problem hiding this comment.
Need to investigate: Why did this change? Should the mempool accept transactions that spend the same prevout? It seems that it used to. Could this be related to the COINBASE_MATURITY change? Doubtful, but possible.
There was a problem hiding this comment.
The old code skipped the mempool validation. The new code is more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to push the TestWallet closer to CWallet. This gives greater functionality to TestWallet, and gives greater chances that it works like a "real" wallet.
Also in this PR: