Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeterministicScheduler should support nanosecond precision #172

Open
carterkozak opened this issue Feb 28, 2020 · 0 comments
Open

DeterministicScheduler should support nanosecond precision #172

carterkozak opened this issue Feb 28, 2020 · 0 comments

Comments

@carterkozak
Copy link

carterkozak commented Feb 28, 2020 •
edited
Loading

Currently DeterministicScheduler converts inputs to milliseconds, which can cause unexpected results when tests expect to operate using finer units.

Proposal:

The default unit should remain milliseconds to avoid breaking scheduling over the max value for existing consumers, but we can provide a constructor which takes an alternate TimeUnit.
carterkozak added a commit to carterkozak/jmock-library that referenced this issue Feb 28, 2020
@carterkozak
fix jmock-developers#172: DeterministicScheduler supports customizabl…
75bd3ec 
…e tick precision

This change adds a constructor which takes a TimeUnit for custom
precision, but does not modify the default constructor in order to
avoid breaking existing tests which could overflow a long using
very long periods of time.
carterkozak added a commit to palantir/dialogue that referenced this issue Feb 28, 2020
@carterkozak
Fork DeterministicScheduler to support nanoseconds
8519b08 
This prevents us from attempting to go back in time. Without allowing
small time-slip we can build confidence that new functionality doesn't
cause us to regress.

Fork will be unnecessary if the upstream fix is accepted:
jmock-developers/jmock-library#172
jmock-developers/jmock-library#173
@carterkozak carterkozak mentioned this issue Feb 28, 2020
Merged
carterkozak added a commit to palantir/dialogue that referenced this issue Feb 28, 2020
@carterkozak
Fork DeterministicScheduler to support nanoseconds
56f179a 
This prevents us from attempting to go back in time. Without allowing
small time-slip we can build confidence that new functionality doesn't
cause us to regress.

Fork will be unnecessary if the upstream fix is accepted:
jmock-developers/jmock-library#172
jmock-developers/jmock-library#173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carterkozak