add optional parameter for additional scrollable areas #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using "table-responsive" there are actually two scrollable areas. The window and the table-responsive-div. Bot need an event listener on "scroll". Since StickyTableHeaders should not know about bootstrap specific things and it could be similar with other UI frameworks this solution is more generic where the user can add scrollable areas that should be observed on his own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue described in #134.
When using bootstraps "table-responsive" for horizontal scrolling there is not just one scrollable area (window) but two (the "table-responsive"-div). The "scroll" events of both must be watched in order to adjust the header on horizontal scrolling too.
Since the StickyTableHeader code should not know about bootstrap specifics and the problem could also occur with other UI layout frameworks/components I added an optional parameter for "additionalScrollableAreas". With that the user can add additional objects for edge cases where more than one scroll-event needs to be watched.
When looking at the example you will most probably be required to shrink your browser window in order to get the table to horizontally scroll.
BR Matthias