Bugfix: Visitor history avatar not displayed when visitor_avatar_id n…

…ot set (Open-Web-Analytics#458) * Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended. * Revert "Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended." This reverts commit b6bd0e5 * Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended.
jmturner · Mar 7, 2020 · 766f68a · 766f68a
1 parent 45f47df
commit 766f68a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/base/templates/report_visitor.tpl b/modules/base/templates/report_visitor.tpl
@@ -1,6 +1,6 @@
 <div>
 	<div style="display: table-cell; vertical-align: middle">
-		<span><img class="owa_avatar" style="vertical-align:middle;" src="<?php echo $this->getAvatarImage( $this->out($this->get('visitor_avatar_id') ) );?>" /></span>
+		<span><img class="owa_avatar" style="vertical-align:middle;" src="<?php $this->out( $this->getAvatarImage( $this->get('visitor_avatar_id') ) );?>" /></span>
 		<span class="inline_h2"><?php $this->out( $visitor_label );?></span>
 	</div>
 	<BR>

diff --git a/owa_template.php b/owa_template.php
@@ -901,7 +901,7 @@ function formatNumber($num, $decimal_places) {
 
 	function getAvatarImage($email) {
 
-		if (false != $email) {
+		if (false != $email && $email !== '(not set)') {
 			$url = sprintf("https://www.gravatar.com/avatar/%s?s=30", md5($email));
 		} else {
 			$url = $this->makeImageLink('base/i/default_user_50x50.png');