Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gherkin 6 (without Rule keyword) #206

Merged
merged 9 commits into from
Nov 16, 2018
Merged

Conversation

gongo
Copy link
Collaborator

@gongo gongo commented Nov 15, 2018

🍕 Motivation

#205

💪 Did

🙅‍♂️ Did not (now)

Support for new Rule keyword that has been introduced in 6.0.
At a later date, I will respond it with another Pull Request.

👀 References

before (Gherkin 5.x)

```rb
children => [
  {
    type: :Background,
    tags: [],
    location: { ... },
    keyword: 'Background',
    name: '...',
    steps: [ ... ],
  },
  {
    type: :Scenario,
    tags: [],
    location: { ... },
    keyword: 'Scenario1',
    name: '...',
    steps: [ ... ]
  },
  {
    type: :Scenario,
    tags: [],
    location: { ... },
    keyword: 'Scenario2',
    name: '...',
    steps: [ ... ]
  },
]
```

after (Gherkin 6.x)

```rb
children => [
  {
    rule: nil,
    background: {
      tags: [],
      location: { ... },
      keyword: 'Background',
      name: '...',
      steps: [ ... ],
    },
    scenario: nil,
  }
  {
    rule: nil,
    background: nil,
    scenario: {
      tags: [],
      location: { ... },
      keyword: 'Scenario1',
      name: '...',
      steps: [ ... ]
    },
  }
  {
    rule: nil,
    background: nil,
    scenario: {
      tags: [],
      location: { ... },
      keyword: 'Scenario2',
      name: '...',
      steps: [ ... ]
    },
  },
]
before (Gherkin 5.x)

```
{
  keyword: 'Given ',
  text: 'text',
  type: 'DocString',
  argument: { ... }
},
{
  keyword: 'Given ',
  text: 'text',
  type: 'DataTable',
  argument: { ... }
}
```

after (Gherkin 6.0)

```
{
  keyword: 'Given ',
  text: 'text',
  doc_string: { ... },
  data_table: nil,
},
{
  keyword: 'Given ',
  text: 'text',
  doc_string: nil,
  data_table: { ... },
}
```
@gongo
Copy link
Collaborator Author

gongo commented Nov 15, 2018

An error occurred while installing google-protobuf (3.6.1), and Bundler

https://travis-ci.org/jnicklas/turnip/jobs/455555759

😇

There is no Java release of google-protobuf version 3.6.1. The latest working Java version seems to be 3.2.0.2. Allow JRuby users to select this older version by loosening the dependency on google-protobuf.

cucumber/common#486

I see

@gongo gongo merged commit f2e7e05 into master Nov 16, 2018
@gongo gongo deleted the support_gherkin6_without_rule branch November 16, 2018 00:03
@gongo gongo mentioned this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants