Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abilities to specify a custom HTTP header and to forgo SSL verification. #8

Merged
merged 3 commits into from
May 14, 2019
Merged

Add abilities to specify a custom HTTP header and to forgo SSL verification. #8

merged 3 commits into from
May 14, 2019

Conversation

FGasper
Copy link

@FGasper FGasper commented May 12, 2019

This adapts functionality from the upstream project.

@FGasper FGasper mentioned this pull request May 12, 2019
Closed
jnordberg
jnordberg reviewed May 14, 2019
View reviewed changes
Copy link
Owner

@jnordberg jnordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looking good. Just one question about your change to the WebSocket constructor I'd like to clear up before merging.

src/wscat.ts Show resolved Hide resolved
@jnordberg jnordberg merged commit 8d6d804 into jnordberg:master May 14, 2019
@FGasper FGasper deleted the http_header branch May 14, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnordberg jnordberg jnordberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FGasper @jnordberg