Updated tests to JUnit5 and Updated Maven Surefire Plugin #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner) This fixes issue jnr#246. Note that there is an intentionally failing test in `FailingTest.java` to show what a failing test could look like on GitHub Actions, I will remove this in the next commit.
…ner) This fixes issue jnr#246. Note that there is an intentionally failing test in `FailingTest.java` to show what a failing test could look like on GitHub Actions, I will remove this in the next commit.
|
Ok good the build failed and the new test runner clearly shows us which test failed with the stacktrace. Nice! |
|
Excellent! Ready to merge now |
# Conflicts: # src/test/java/jnr/ffi/LibraryLoaderTest.java # src/test/java/jnr/ffi/PlatformTest.java
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #246
Note that there is an intentionally failing test in
FailingTest.javato show what a failing test could look like on GitHub Actions, I will remove this in the next commitThis PR changes no functionality or behaviors, only updates tests to use JUnit5, the large number of changes is because of the changes in parameter order for JUnit5's
asserts which place themessageat the end instead of the beginning.I also intentionally did not change formatting or style to make reviewing much easier and keep changes to a minimum.