This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Allow deploying latest build again #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current deployable check does not allow to redeploy the same deployment once again. Meaning if your deployment gets corrupted somehow you cannot delete it and deploy it again. As an example, Airflow (jobflow) currently as a bug due to missing support for certain kubernetes resources which can have it looses track of some of the resources it created in k8s. The only work around seem to delete and create again the deployment (_cf._ apache/airflow#21087).
cansjt
commented
Mar 28, 2022
Comment on lines
+46
to
+51
| # List commits behind the latest deployment tag, to see if the current commit is not behind. | ||
| # Exclude the tagged commit itself so we can redeploy an already deployed, and thus tagged, | ||
| # commit. | ||
| # Why isn't it enough to check that "${deployed_sha1}" != "${current_sha1}"? | ||
| if { git rev-list "^${deployed_sha1}" | grep -q "${current_sha1}" ; } | ||
| then |
There was a problem hiding this comment.
Maybe the logic is a bit backwards here: what we want is to know if the latest commit taggged as a deployment is reachable from HEAD. In which case we are either ahead of the latest deployment or the latest deployment.
-----o----o----o----o HEAD
\-<= label
But what we check is whether the HEAD is behind the latest tag, which seem much more complicated to check.
The whole code from line 37 onwards, can be replaced with a single check:
if ! { git rev-list HEAD | \
grep -q "$(git tag --sort version:refname --format "%(objectname)" --list "deploiment-*" | \
tail -1)" ; }
then
fatal "the current build is older than the deployed one"
fi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deployable check does not allow to redeploy the same deployment once again. Meaning if your deployment gets corrupted somehow you cannot delete it and deploy it again.
As an example, Airflow (jobflow) currently as a bug due to missing support for certain kubernetes resources which can have it looses track of some of the resources it created in k8s. The only work around seem to delete and create again the deployment (cf. apache/airflow#21087).
This commit changes the check so the latest build can be redeployed.