Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DotNetLightning.ClnRpc #186

Merged
merged 21 commits into from
May 19, 2022
Merged

add DotNetLightning.ClnRpc #186

merged 21 commits into from
May 19, 2022

Conversation

joemphilips
Copy link
Owner

This commit adds a new project for calling c-lightning from .NET
in a typesafe way.
Most of the codes are auto-generated from client generator built in
ref: ElementsProject/lightning#5201

It must be updated after ElementsProject/lightning#5216 gets merged.
So that all the generation logics is defined in this repo.
But this is good enough for temporary solution.

@joemphilips
Copy link
Owner Author

Before this get merged, I must review and merge #184
and do some cleanup...

@knocte
Copy link
Collaborator

knocte commented Apr 24, 2022

I must review and merge #184

And after #184 I'll merge the other approved ones before this one, if you don't mind.

@knocte

This comment was marked as outdated.

@joemphilips joemphilips force-pushed the add_cln_client branch 3 times, most recently from a1487cd to 014ec72 Compare April 28, 2022 01:42
@knocte
Copy link
Collaborator

knocte commented Apr 28, 2022

To prevent the style CI lane from failing on auto-generated files, you can add those files to a .fantomasignore file.

@joemphilips joemphilips force-pushed the add_cln_client branch 7 times, most recently from b3fa544 to 92f348b Compare May 2, 2022 13:04
@joemphilips joemphilips force-pushed the add_cln_client branch 9 times, most recently from 1c35015 to be54944 Compare May 7, 2022 11:03
@joemphilips joemphilips force-pushed the add_cln_client branch 3 times, most recently from 598b431 to 6d59300 Compare May 19, 2022 01:10
@joemphilips joemphilips force-pushed the add_cln_client branch 2 times, most recently from 27f83f3 to 3f10d82 Compare May 19, 2022 04:47
This commit adds a new project for calling c-lightning from .NET
in a typesafe way.
Most of the codes are auto-generated from client generator built in
ref: ElementsProject/lightning#5201

It must be updated after ElementsProject/lightning#5216 gets merged.
So that all the generation logics is defined in this repo.
But this is good enough for temporary solution.
This was originally necessary for private nuget feed.
But since we stopped using it long time ago, it is no
longer needed.
It also start supporting injecting transport stream from outside.
These are necessary for building plugin.
@joemphilips joemphilips force-pushed the add_cln_client branch 2 times, most recently from d9b3930 to 1bf11f1 Compare May 19, 2022 05:47
Sometimes the test hangs only in CI environment.
This option shall make our life easier by aborting early.
* Since it does not work in CI environment
@joemphilips joemphilips force-pushed the add_cln_client branch 2 times, most recently from 94dbdfd to 70aabd0 Compare May 19, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants