Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression modules not loaded reliably #6

Closed
tgstaples opened this issue Jun 7, 2021 · 4 comments
Closed

compression modules not loaded reliably #6

tgstaples opened this issue Jun 7, 2021 · 4 comments
Assignees
Labels

Comments

@tgstaples
Copy link

I have noticed that compression modules are not loaded reliably. On our RH7 Linux machines, I only get bz2 on ST3 startup. Here is a snippet from the console...

reloading plugin Compressor.Compressor
bz2
plugins loaded

If I disable/enable Compressor while ST3 is running I get bz2 and gzip...

ignored packages updated to: ["Anaconda", "Compressor", "Vintage"]
unloading plugin Compressor.Compressor
reloading settings Packages/User/Preferences.sublime-settings
ignored packages updated to: ["Anaconda", "Vintage"]
reloading plugin Compressor.Compressor
bz2
gzip
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings

I think this issue can be fixed by using plugin_loaded() ST3 api like below and remove the call load_modules() in the OpenCompressedFile3() constructor.

def plugin_loaded():
    load_modules(COMPRESSION_MODULES)
@dvhh
Copy link
Collaborator

dvhh commented Jun 8, 2021

Looking at it, thanks for the suggestion

@dvhh dvhh self-assigned this Jun 10, 2021
@dvhh dvhh added the bug label Jun 10, 2021
dvhh added a commit to dvhh/sublime-compressor that referenced this issue Jun 14, 2021
For  call  in  rather than
@dvhh
Copy link
Collaborator

dvhh commented Jun 14, 2021

@tgstaples would you kindly test my fork which implement your request ?

@tgstaples
Copy link
Author

@tgstaples would you kindly test my fork which implement your request ?

Appears to be working. Thanks!

reloading plugin Compressor2.Compressor
plugins loaded
gzip
bz2

@dvhh
Copy link
Collaborator

dvhh commented Jun 19, 2021

thanks for confirming

dvhh added a commit that referenced this issue Jun 19, 2021
* LZMA test

- use of backports.lzma for sublime-text 2 (python 2.6)
- corrected header bytes
- handling of files that are smaller than the headers

* backports.lzma for all windows version

* corrected key

* Update dependencies.json

* test

* Update dependencies.json

* remove period in name

reflecting https://github.com/dvhh/package_control_channel/commit/6989ebf39ac119f5e6d7de4b6e73ac57782a91bf

* update used module for lzma

* fix for #6
For  call  in  rather than

* cleanup
@dvhh dvhh closed this as completed Jun 19, 2021
dvhh added a commit to dvhh/sublime-compressor that referenced this issue Jun 19, 2021
* LZMA test

- use of backports.lzma for sublime-text 2 (python 2.6)
- corrected header bytes
- handling of files that are smaller than the headers

* backports.lzma for all windows version

* corrected key

* Update dependencies.json

* test

* Update dependencies.json

* remove period in name

reflecting https://github.com/dvhh/package_control_channel/commit/6989ebf39ac119f5e6d7de4b6e73ac57782a91bf

* update used module for lzma

* fix for joernhees#6
For  call  in  rather than

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants