-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat schedule picker popover #3796
base: master
Are you sure you want to change the base?
Feat schedule picker popover #3796
Conversation
I ran this on my machine to play around. As mentioned in the original discussion: This might not work too well for desktop since it breaks the keyboard flow (makes only sense to to use the up and down keys imho). I can see this or something similar being added as via an additional button on mobile though. |
What do you mean by breaking the keyboard flow? If a popup appears, then the focus is inevitably on it, unless one clicks outside to close it? Isn't it the same with angular-mention? |
For all the other short syntax stuff e.g. for tags and projects you are still able to type (moving the cursor left and right in the input field is not affected). You still can use the suggestions by moving array keys up and down, but you also can just continue typing freely. I think that is how it should be. |
Description
A rough custom implementation for popover. It's like dialog, but less intrusive. Developer can pass a custom component to it to render anything into this popover. It still needs further feedback in order to be complete.
Issues Resolved
Potentially resolves #3544 . Popover can be passed a calendar picker that allows uses to select date while adding new task.
Check List